[PVFS-developers] do_lstat doesn't cache file size
Rob Ross
rross@mcs.anl.gov
Thu, 15 Jan 2004 11:10:32 -0600 (CST)
Hi,
Second of the two patches has been applied in CVS. Thanks!
You've set a new high bar by providing multiple patch versions for me to
choose from :).
Rob
On Wed, 24 Dec 2003, Porter Don wrote:
>
> I just noticed that in pvfs 1.6.2, there is a do_lstat function added to the
> manager. This function is a cut-n-paste of do_stat, except that it doesn't
> follow links and copies the size of the file into the 64-bit fsize field.
>
> In the course of cutting/pasting, my changes to cache the file size on the
> manager were missed. Attached is one patch (lstat-cache-1.6.2.patch) that
> copies these changes into this function as well.
>
> I got to thinking, though, and it seems like the code would be more
> streamlined and less likely to develop such inconsistencies if these two
> functions were merged. There are only about 2 lines of code difference
> between them. Attached is a second patch (lstat-cache-2-1.6.2.patch) that
> just checks which call it is supposed to be before calling md_stat and uses
> FOLLOW or NOFOLLOW accordingly. This removes a lot of what seems like
> redundant code.
>
> Thanks,
> don porter