[PVFS-developers] link-unlink-fix.patch

[Rob Ross]

My plan is to cut the hardlink code back out or make it an unsupported
option, as it causes problems like this and at this point in the PVFS life 
cycle adding new functionality is a bad idea.

I've already disabled the hardlink support in the mgr by default towards 
this end.

Regards,

Rob

On Fri, 30 Jul 2004, Stuart White wrote:

> In mgr/meta/md_unlink.c, code exists that prevents the data files on
> the IODs from being deleted when a symbolic link is removed.
> 
>    if(S_ISLNK(statbuf.st_mode)) {
> 
> It seems this code does not handle hard links properly.  If the number
> of hard links on a file is greater than 1, the manager should still not
> instruct the IODs to remove the data for the file.
> 
> Only when a regular file with the number of links == 1 is removed
> should the actual data be removed on the IODs.
> 
>    if(S_ISLNK(statbuf.st_mode) || (S_ISREG(statbuf.st_mode) &&
> (statbuf.st_nlink > 1))) {
> 
> The attached patch applies to 1.6.3-pre2.
> 
> Feedback is appreciated.  Thanks!
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around 
> http://mail.yahoo.com