[PVFS-developers] do_access bug

Porter Don PorterDE at mercury.hendrix.edu
Tue Jun 15 11:55:12 EDT 2004


Greetings all,

I found a small bug in the semantics of do_access.  It misses the case of a
file that is 770, owned by someone else, and owned by a group of which one
is a member, but that group is not the user's default group.  This is
because the function only check if the request's gid is equal to the gid
that owns the file.

I fixed this by changing that line to a call to in_group() with the uid of
the request and the target group.  Thus, the user's membership in the given
group is checked.

I also went ahead and added the case that the request came from root,
allowing root to do whatever (s)he so desires.

Patch attached as usual.

Thanks,
Don

-------------- next part --------------
A non-text attachment was scrubbed...
Name: do_access.patch
Type: application/octet-stream
Size: 1615 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs-developers/attachments/20040615/551010e8/do_access.obj


More information about the PVFS-developers mailing list