[PVFS-developers] metadata file size checking

Rob Ross rross at mcs.anl.gov
Wed May 19 13:45:24 EDT 2004


Also, the "something is very wrong here" message is *very* misleading; 
it's popping out all the time when the file doesn't exist...

So I think we need to remove that too.

Rob

On Wed, 19 May 2004, Rob Ross wrote:

> Don,
> 
> I've applied your patch to CVS, but I'm thinking I might simplify this a
> bit more before we're done.
> 
> Here's what I'm thinking: rather than having meta_creat() call meta_open()
> at the end, just have it explicitly re-open on its own.  This will allow
> us to avoid the extra write() of dummy data.
> 
> I've attached a patch.  Lemme know what you think.  Sorry that there is 
> formatting junk in there that is distracting from the real purpose.
> 
> And thanks for the original patch!
> 
> Rob
> 
> On Thu, 6 May 2004, Porter Don wrote:
> 
> > I wanted to implement some protection against overwriting a metadata file
> > that has not had the migration script run on it after an upgrade.  So I
> > ended up stat-ing the file in meta-open and if it is not a directory and its
> > size is not the same as a struct fmeta, then the manager will return an
> > EINVAL (open to suggestions for better error code) and print a message to
> > logs.  See below:
> 



More information about the PVFS-developers mailing list