[PVFS-developers] metadata file size checking

[Porter Don]

That sounds good to me.  The patch I sent was just a first cut that seemed
to work.  I am all for code consolidation and elegance. 

-----Original Message-----
From: Rob Ross
To: Porter Don
Cc: 'pvfs-developers at www.beowulf-underground.org'
Sent: 5/19/04 11:24 AM
Subject: Re: [PVFS-developers] metadata file size checking

Don,

I've applied your patch to CVS, but I'm thinking I might simplify this a
bit more before we're done.

Here's what I'm thinking: rather than having meta_creat() call
meta_open()
at the end, just have it explicitly re-open on its own.  This will allow
us to avoid the extra write() of dummy data.

I've attached a patch.  Lemme know what you think.  Sorry that there is 
formatting junk in there that is distracting from the real purpose.

And thanks for the original patch!

Rob

On Thu, 6 May 2004, Porter Don wrote:

> I wanted to implement some protection against overwriting a metadata
file
> that has not had the migration script run on it after an upgrade.  So
I
> ended up stat-ing the file in meta-open and if it is not a directory
and its
> size is not the same as a struct fmeta, then the manager will return
an
> EINVAL (open to suggestions for better error code) and print a message
to
> logs.  See below:
 <<>>