[PVFS2-CVS] commit by neill in pvfs2/src/io/trove/trove-dbpf: dbpf-dspace.c dbpf-keyval-db-cache.c

[CVS commit program]

Update of /projects/cvsroot/pvfs2/src/io/trove/trove-dbpf
In directory parlweb:/tmp/cvs-serv28225/src/io/trove/trove-dbpf

Modified Files:
	dbpf-dspace.c dbpf-keyval-db-cache.c 
Log Message:
- misc cleanups


Index: dbpf-dspace.c
===================================================================
RCS file: /projects/cvsroot/pvfs2/src/io/trove/trove-dbpf/dbpf-dspace.c,v
diff -p -u -r1.95 -r1.96
--- dbpf-dspace.c	3 May 2004 17:32:19 -0000	1.95
+++ dbpf-dspace.c	3 May 2004 19:48:46 -0000	1.96
@@ -370,22 +370,22 @@ static int dbpf_dspace_remove_op_svc(str
     /* if this attr is in the dbpf attr cache, remove it */
     dbpf_attr_cache_remove(ref);
 
-    /* remove keyval db if it exists
-     *
-     * NOTE: this is not a fatal error; this might have never been
-     * created.
-     */
+    /*
+      remove keyval db if it exists. failure here is not a fatal
+      error; this might have never been created.
+    */
     ret = dbpf_keyval_dbcache_try_remove(
         op_p->coll_p->coll_id, op_p->handle);
 
     DBPF_DB_SYNC_IF_NECESSARY(op_p, db_p);
 
-    /* remove bstream file if it exists
-     *
-     * NOTE: this is not a fatal error; this might have never been created.
-     */
+    /*
+      remove bstream file if it exists. failure here is not a fatal
+      error; this might have never been created.
+    */
     ret = dbpf_bstream_fdcache_try_remove(
         op_p->coll_p->coll_id, op_p->handle);
+
     switch (ret)
     {
 	case DBPF_BSTREAM_FDCACHE_BUSY:

Index: dbpf-keyval-db-cache.c
===================================================================
RCS file: /projects/cvsroot/pvfs2/src/io/trove/trove-dbpf/dbpf-keyval-db-cache.c,v
diff -p -u -r1.39 -r1.40
--- dbpf-keyval-db-cache.c	3 May 2004 19:03:01 -0000	1.39
+++ dbpf-keyval-db-cache.c	3 May 2004 19:48:46 -0000	1.40
@@ -21,9 +21,6 @@
 #include "dbpf.h"
 #include "dbpf-keyval.h"
 
-/* NOTE: THIS IS ALMOST CERTAINLY BROKEN FOR MULTITHREADED APPS!!!
- */
-
 enum
 {
     DBCACHE_ENTRIES = 16
@@ -77,7 +74,7 @@ void dbpf_keyval_dbcache_finalize(void)
 /* dbpf_keyval_dbcache_try_remove()
  *
  * Returns 0 on success, or one of -TROVE_EBUSY, -TROVE_ENOENT, or
- * -TROVE_EPERM (for now).
+ * -TROVE_EPERM.
  *
  */
 int dbpf_keyval_dbcache_try_remove(TROVE_coll_id coll_id,
@@ -162,8 +159,6 @@ int dbpf_keyval_dbcache_try_remove(TROVE
  * might change at some later time.
  *
  * Returns 0 on success, -TROVE_errno on failure.
- *
- * TODO: DO A BETTER JOB OF MAPPING ERROR VALUES!
  *
  * create_flag - 0 = don't create if doesn't exist; non-zero = create.
  */