[PVFS2-CVS] commit by neill in pvfs2/test/client/sysint: ls.c

CVS commit program cvs at parl.clemson.edu
Tue Oct 19 12:02:53 EDT 2004


Update of /projects/cvsroot/pvfs2/test/client/sysint
In directory parlweb:/tmp/cvs-serv31256/test/client/sysint

Modified Files:
	ls.c 
Log Message:
- fixed test program ls.c and admin program pvfs2-ls.c to not issue
  an extra call to readdir on every run by fixing a slight logic bug
- changed some readdir debugging
- added a directory version that is passed back from the server to
  the client on each successful readdir call (happens to be the
  directory's mtime encoded as an opaque uint64_t)
- updated client and server response structures and encoder to
  accomodate this
- NOTE: the versioning is not perfect since retrieving the directory
  mtime and iterating the handle list isn't an atomic operation with
  respect to the overall readdir op; i.e. there's still a window where
  a difference may not be detected.  then again, since the mtime is in
  seconds granularity, this should not present a major detectable
  problem anyway.  can use a different version number if problems
  arise often in practice


Index: ls.c
===================================================================
RCS file: /projects/cvsroot/pvfs2/test/client/sysint/ls.c,v
diff -p -u -r1.30 -r1.31
--- ls.c	14 Jun 2004 21:48:44 -0000	1.30
+++ ls.c	19 Oct 2004 15:02:52 -0000	1.31
@@ -179,7 +179,7 @@ int do_list(
         if (rd_response.pvfs_dirent_outcount)
             free(rd_response.dirent_array);
 
-    } while(rd_response.pvfs_dirent_outcount != 0);
+    } while(rd_response.pvfs_dirent_outcount == pvfs_dirent_incount);
 
     return 0;
 }



More information about the PVFS2-CVS mailing list