[Pvfs2-cvs] commit by vilayann in pvfs2/src/server: chdirent.sm crdirent.sm rmdirent.sm

CVS commit program cvs at parl.clemson.edu
Wed Aug 9 00:43:51 EDT 2006


Update of /anoncvs/pvfs2/src/server
In directory parlweb1:/tmp/cvs-serv5791/src/server

Modified Files:
	chdirent.sm crdirent.sm rmdirent.sm 
Log Message:
- Misc. cleanups (replaced a big macro with an inline function)
- Removed parent_*time from the *dirent request protocol since time stamps are now
kept at the server and do not need to be sent over the wire (This is the reason why
major version of the wire protocol has been bumped)
- Adjust macros for the *dirent protocol accordingly.
- Add a few more debugging statements to kmod






Index: chdirent.sm
===================================================================
RCS file: /anoncvs/pvfs2/src/server/chdirent.sm,v
diff -p -u -r1.13 -r1.14
--- chdirent.sm	1 Aug 2006 00:27:16 -0000	1.13
+++ chdirent.sm	9 Aug 2006 04:43:51 -0000	1.14
@@ -253,12 +253,7 @@ static int chdirent_change_directory_ent
         0,
         NULL, s_op, 0, js_p, &j_id, server_job_context);
 
-    if (s_op->req->u.chdirent.parent_atime ||
-        s_op->req->u.chdirent.parent_mtime ||
-        s_op->req->u.chdirent.parent_ctime)
-    {
-        s_op->u.chdirent.dir_attr_update_required = 1;
-    }
+    s_op->u.chdirent.dir_attr_update_required = 1;
     return ret;
 }
 

Index: crdirent.sm
===================================================================
RCS file: /anoncvs/pvfs2/src/server/crdirent.sm,v
diff -p -u -r1.62 -r1.63
--- crdirent.sm	1 Aug 2006 00:27:16 -0000	1.62
+++ crdirent.sm	9 Aug 2006 04:43:51 -0000	1.63
@@ -308,15 +308,9 @@ static int crdirent_write_directory_entr
         NULL, s_op, 0, js_p, &i, server_job_context);
 
     /*
-      check if any attributes have changed on the parent that require
-      an update; object times only are considered
-    */
-    if (s_op->req->u.crdirent.parent_atime ||
-        s_op->req->u.crdirent.parent_mtime ||
-        s_op->req->u.crdirent.parent_ctime)
-    {
-        s_op->u.crdirent.dir_attr_update_required = 1;
-    }
+     * creating an entry will cause directory times to be updated.
+     */
+    s_op->u.crdirent.dir_attr_update_required = 1;
     return ret;
 }
 

Index: rmdirent.sm
===================================================================
RCS file: /anoncvs/pvfs2/src/server/rmdirent.sm,v
diff -p -u -r1.49 -r1.50
--- rmdirent.sm	1 Aug 2006 00:27:16 -0000	1.49
+++ rmdirent.sm	9 Aug 2006 04:43:51 -0000	1.50
@@ -197,12 +197,10 @@ static int rmdirent_remove_directory_ent
         flags,
         NULL, s_op, 0, js_p, &j_id, server_job_context);
 
-    if (s_op->req->u.rmdirent.parent_atime ||
-        s_op->req->u.rmdirent.parent_mtime ||
-        s_op->req->u.rmdirent.parent_ctime)
-    {
-        s_op->u.rmdirent.dir_attr_update_required = 1;
-    }
+    /* 
+     * Removing an entry causes an update of directory timestamps
+     */
+    s_op->u.rmdirent.dir_attr_update_required = 1;
     return ret;
 }
 



More information about the Pvfs2-cvs mailing list