[PVFS2-CVS]
commit by robl in pvfs2-1/src/kernel/linux-2.6: pvfs2-kernel.h
CVS commit program
cvs at parl.clemson.edu
Fri Jan 13 17:16:04 EST 2006
Update of /projects/cvsroot/pvfs2-1/src/kernel/linux-2.6
In directory parlweb:/tmp/cvs-serv9164/src/kernel/linux-2.6
Modified Files:
pvfs2-kernel.h
Log Message:
[pcarns]: make_bad_inode() will cause the inode count to go off by one if
triggered here and would not get cleaned up until module unload time.
Index: pvfs2-kernel.h
===================================================================
RCS file: /projects/cvsroot/pvfs2-1/src/kernel/linux-2.6/pvfs2-kernel.h,v
diff -u -w -p -u -r1.108 -r1.109
--- pvfs2-kernel.h 20 Dec 2005 15:33:57 -0000 1.108
+++ pvfs2-kernel.h 13 Jan 2006 22:16:04 -0000 1.109
@@ -1038,10 +1038,18 @@ static inline int pvfs2_internal_revalid
* would be refreshed, so we dont have much of a choice here too.
*/
ret = ((pvfs2_inode_getattr(inode, PVFS_ATTR_SYS_ALL) == 0) ? 1 : 0);
+#if 0
+/* Calling make_bad_inode() here results in a bad reference count on the
+ * inode. It therefore gets cached until the module is unloaded, when we get
+ * a "VFS: Busy inodes after unmount. Self-destruct in 5 seconds." error
+ * message. It is better to just let it be cleaned up naturally after
+ * validation failure. -Phil
+ */
if (ret == 0)
{
pvfs2_make_bad_inode(inode);
}
+#endif
}
return ret;
}
More information about the PVFS2-CVS
mailing list