[Pvfs2-cvs] commit by pw in pvfs2/src/io/bmi: bmi-method-support.h

CVS commit program cvs at parl.clemson.edu
Wed Jul 18 17:32:57 EDT 2007


Update of /projects/cvsroot/pvfs2/src/io/bmi
In directory parlweb1:/tmp/cvs-serv15937/src/io/bmi

Modified Files:
	bmi-method-support.h 
Log Message:
Move private method parameters structures to their respective methods.


Index: bmi-method-support.h
===================================================================
RCS file: /projects/cvsroot/pvfs2/src/io/bmi/bmi-method-support.h,v
diff -u -p -p -u -r1.28 -r1.29
--- bmi-method-support.h	18 Jul 2007 21:04:00 -0000	1.28
+++ bmi-method-support.h	18 Jul 2007 21:32:57 -0000	1.29
@@ -171,7 +171,13 @@ struct bmi_method_ops
 };
 
 
-/* this is the internal structure used to represent method operations */
+/*
+ * This structure is somewhat optional.  TCP and GM use the elements in
+ * here extensively, but IB, MX, Portals only use the bits required by
+ * the generic BMI layer.  Those are op_id and addr.  Everything else is
+ * ignored.  Would be nice to push most of method_op down into TCP and GM
+ * so other BMI implementations do not need to drag around the unused fields.
+ */
 struct method_op
 {
     bmi_op_id_t op_id;		/* operation identifier */
@@ -203,15 +209,6 @@ struct method_op
     bmi_size_t cur_index_complete;
 };
 typedef struct method_op method_op_st, *method_op_p;
-
-/* generic method parameters */
-struct method_params
-{
-    int method_flags;
-    int method_id;
-    method_addr_p listen_addr;
-};
-typedef struct method_params method_params_st, *method_params_p;
 
 struct method_drop_addr_query
 {



More information about the Pvfs2-cvs mailing list