[Pvfs2-cvs] commit by slang in pvfs2/src/apps/admin: pvfs2-genconfig

CVS commit program cvs at parl.clemson.edu
Mon Feb 18 12:00:53 EST 2008


Update of /projects/cvsroot/pvfs2/src/apps/admin
In directory parlweb1:/tmp/cvs-serv5914/src/apps/admin

Modified Files:
	pvfs2-genconfig 
Log Message:
The config file was limited to 16K because of a #define limit in pvfs2-req-proto.h.  I've increased the limit to 64K, which only limits the size of the allocated response structure.  Since the response can have an unlimited size, the config file size shouldn't be limited by the size of eager mode messages in BMI.
Also added the requested warning message to genconfig for config files larger than the limit, which is somewhere around 512 servers now.


Index: pvfs2-genconfig
===================================================================
RCS file: /projects/cvsroot/pvfs2/src/apps/admin/pvfs2-genconfig,v
diff -p -u -r1.77 -r1.78
--- pvfs2-genconfig	10 Dec 2007 17:38:50 -0000	1.77
+++ pvfs2-genconfig	18 Feb 2008 17:00:53 -0000	1.78
@@ -1505,7 +1505,6 @@ my $client_job_timeout = get_client_job_
 
 if (!$opt_quiet) {
     print $OUT "Writing fs config file... ";
-    print $OUT "done\n";
 }
 
 emit_defaults($output_target, $num_unexp_reqs,
@@ -1528,8 +1527,22 @@ if ($opt_metaspec) {
 if ($using_stdout == 0)
 {
     close($output_target);
+
+    my $req_limit = 65536;
+
+    if(-s $ARGV[0] > $req_limit)
+    {
+        my $size = (-s $ARGV[0]);
+        print STDERR
+"Warning: Generated config file: " . $ARGV[0] . "\n" .
+"has size: $size, which is larger than the current PVFS request: $req_limit\n" .
+"Increase the value of PVFS_REQ_LIMIT_CONFIG_FILE_BYTES in src/proto/pvfs2-req-proto.h\n";
+    }
 }
 
+if (!$opt_quiet) {
+    print $OUT "done\n";
+}
 
 # Local variables:
 #  c-indent-level: 4



More information about the Pvfs2-cvs mailing list