[Pvfs2-cvs] commit by mtmoore in pvfs2/src/io/trove/trove-dbpf:
dbpf-bstream.c
CVS commit program
cvs at parl.clemson.edu
Tue Feb 2 13:17:51 EST 2010
Update of /projects/cvsroot/pvfs2/src/io/trove/trove-dbpf
In directory parlweb1:/tmp/cvs-serv16891/pvfs2/src/io/trove/trove-dbpf
Modified Files:
Tag: Orange-Branch
dbpf-bstream.c
Log Message:
fix gossip_debug segfault when trove debugging is enabled
Index: dbpf-bstream.c
===================================================================
RCS file: /projects/cvsroot/pvfs2/src/io/trove/trove-dbpf/dbpf-bstream.c,v
diff -p -u -r1.93.2.1 -r1.93.2.2
--- dbpf-bstream.c 14 Oct 2009 16:55:12 -0000 1.93.2.1
+++ dbpf-bstream.c 2 Feb 2010 18:17:51 -0000 1.93.2.2
@@ -241,17 +241,12 @@ error_in_cleanup:
* the signal'd thread executes before the following gossip_debug statement, then cur_op is un-
* defined, causing the gossip_debug statement to seg fault. So, we check for existence first!
*/
- if (cur_op)
- {
- gossip_debug(GOSSIP_TROVE_DEBUG, "*** starting delayed ops if any "
- "(state is %s)\n",
- list_proc_state_strings[
- op_p->u.b_rw_list.list_proc_state]);
- }
- else
- {
- gossip_debug(GOSSIP_TROVE_DEBUG,"*** starting delayed ops if any. (cur_op undefined).\n");
- }
+
+ /* if the signal'd thread executes op_p can also go away
+ * causing the list_proc_state access to segfault. there isn't really
+ * much debugging information to be had by accessing cur_op or
+ * op_p, the key is that delayed ops are starting. */
+ gossip_debug(GOSSIP_TROVE_DEBUG,"*** starting delayed ops if any.\n");
start_delayed_ops_if_any(1);
}
More information about the Pvfs2-cvs
mailing list