[Pvfs2-cvs] commit by mtmoore in pvfs2/include: pvfs2-types.h
CVS commit program
cvs at parl.clemson.edu
Fri Feb 25 17:20:48 EST 2011
Update of /projects/cvsroot/pvfs2/include
In directory parlweb1:/tmp/cvs-serv30157/include
Modified Files:
Tag: Orange-Branch
pvfs2-types.h
Log Message:
fix to segfault in list-eattr if client provides too large of buffer, found by Mike Marshall. Also includes other changes to enforce attribute name, value and list lengths for eattr operations on the server side and list-eattr on the client side.
Index: pvfs2-types.h
===================================================================
RCS file: /projects/cvsroot/pvfs2/include/pvfs2-types.h,v
diff -p -u -r1.156.10.7 -r1.156.10.8
--- pvfs2-types.h 21 Dec 2010 15:34:14 -0000 1.156.10.7
+++ pvfs2-types.h 25 Feb 2011 22:20:47 -0000 1.156.10.8
@@ -488,9 +488,13 @@ endecode_fields_2(
* upcall request types.
* NOTE: Please retain them as multiples of 8 even if you wish to change them
* This is *NECESSARY* for supporting 32 bit user-space binaries on a 64-bit kernel.
+ * Due to implementation within DBPF, this really needs to be PVFS_NAME_MAX,
+ * which it was the same value as, but no reason to let it break if that
+ * changes in the future.
*/
-#define PVFS_MAX_XATTR_NAMELEN 256 /* Not the same as XATTR_NAME_MAX defined
- by <linux/xattr.h> */
+#define PVFS_MAX_XATTR_NAMELEN PVFS_NAME_MAX /* Not the same as
+ XATTR_NAME_MAX defined
+ by <linux/xattr.h> */
#define PVFS_MAX_XATTR_VALUELEN 8192 /* Not the same as XATTR_SIZE_MAX defined
by <linux/xattr.h> */
#define PVFS_MAX_XATTR_LISTLEN 8 /* Not the same as XATTR_LIST_MAX
More information about the Pvfs2-cvs
mailing list