[PVFS2-developers] Tabs and Spaces and Bears, Oh My!
poznick at conwaycorp.net
Tue Jul 27 22:06:37 EDT 2004
Thus spake Phil Carns:
> Heh, sorry about that :) I was just rolling with the vim settings we had. I
> actually don't care one way or the other on the tab/space issue, as long as I
> know which way to go.
Well, I'm willing to submit a (new, since some things have changed)
patch to fix the noexpandtab -> expandtab, and I'm even willing to do
the tab -> spaces normalization on Phil's half of the tree. I just
wouldn't want to catch anyone in the middle of a large set of changes in
their local copies, where it could turn a cvs update into a pain in the
Here's an updated version of the patch to fix the modelines for vim
(regenerated after the afternoon's commits, apply with -p0):
And here's a massive patch (applied over top of the expandtab patch)
which converts tabs to spaces (apply with -p1) in all .c, .h, .sm, .y,
and .l files (only one each of the last two, but they were stragglers).
It's big, and in places it looks odd because in some files only a few
lines here and there had tabs instead of spaces, but the ONLY
differences in this patch are tab->space conversions.
I was lazy in how I generated it. Since :retab in vim does such a
wonderful job of doing things Properly, I figured I'd just let :retab in
vim do the job, so I used,
for i in `find -type f -name \*.c -or -name \*.h -or -name \*.sm -or -name \*.y -or -name \*.l`; do vim -c retab -c wq $i; done
I've scanned through the whole patch (that took a while!), and it
looks like everything happened properly.
Nathan Poznick <poznick at conwaycorp.net>
A man must be both stupid and uncharitable who believes there is no
virtue or truth but on his own side. - Joseph Addison
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20040727/3ec681f8/attachment-0001.bin
More information about the PVFS2-developers