[PVFS2-developers] Removing of a directory

[Julian Martin Kunkel]

Hi,
> > 1.  rmdirent(object name,parent handle) => object handle
> > 2.  getattr(object handle) => attr
> > 3.  remove(object handle) => ENOTEMPTY
> > 4.  crdirent(object_handle)
> Ahh, you are right.  I didn't realize that the attributes weren't read
> until after removing the directory entry.  With that being the case it
> would have to come after step 2) as you say, although that isn't as
> helpful as if we had the information earlier.
I don't think this would be helpful because it won't change something. If a 
client breaks after step 1 the directory object is gone, even if it has 
objects inside.
Currently you check whether the directory is empty directly after step 2.

>From my opinion the problem is that you don't check the directory state before 
you remove in step 1 the directory entry.
Yes of course you can't do this because you get the object handle while 
rmdirent. 
A idea would be to first lookup the object name to get the object handle and 
then getattr (handle) and then look if it's empty or not (like it is 
currently done). If it's empty do rmdirent and then remove object. The 
mechanism with the ENOTEMPTY and crdirent can be keept in case somebody 
creates a object in that directory while another client checked the number of 
directory entries with getattr.

Julian