[PVFS2-developers] patch: misc. memory cleanups

[Robert Latham]

On Wed, Feb 16, 2005 at 08:48:18PM +0100, Phil Carns wrote:
> Hi all,
> 
> I tried running a pvfs2 server through in Parasoft's Insure tool the 
> other week and found some issues.  Unfortunately, the tool crashed when 
> requests were actually sent to the server, but I at least cleaned up a 
> few things found at compile or at server initialization time.
> 
> I attached several seperate patches to make it easier to see what they 
> change; the fixes are rather scattered.  Summary listed below, in order 
> of importance
> 
> -Phil
> ------------------------------------
> 
> job-desc-locking.patch:
> locking was added to the job-desc queue at some point, but I found a 
> couple of problems: each new queue construction destroyed a global 
> (rather than per queue) lock, some functions were unprotected, and some 
> functions were protected in duplicate at the job layer.  To fix, I 
> removed these locks from the job-desc-queue and expanded the locking at 
> the job layer a bit to make sure that every queue access is protected by 
> an external mutex.

Ok, this one took me a little while to understand, but I've added it
to cvs.  I can't belive it took me 4 months to get around to this one.  

==rob

-- 
Rob Latham
Mathematics and Computer Science Division    A215 0178 EA2D B059 8CDF
Argonne National Labs, IL USA                B29D F333 664A 4280 315B