[PVFS2-developers] current cvs weirdness
pcarns at wastedcycles.org
Tue Jun 7 23:43:59 EDT 2005
Robert Latham wrote:
> On Tue, May 24, 2005 at 11:19:58PM +0200, Phil Carns wrote:
>>Changing the strip_size variable to a PVFS_size instead of int and
>>adjusting the sscanf in the argument parser accordingly fixes the
>>problem. The same bug afflicts the create-with-dist.c test program in
>>test/client/sysint as well, but with less disasterous results (but still
>>a very wrong strip size).
> I fixed this in CVS.
> Is there a way to make sure users know they passed in a too-small
> variable to the distribution code? that void * means the compiler
> won't catch anything, but is there something else we can do?
Thanks for applying the fix. As best I can figure there isn't anything
to be done about it with that void* being there. The alternative would
be to make a new api hook that has a typed argument. Probably most of
the values that people would want to twiddle at run time can be
expressed as a 64 bit signed integer. The void* version could be left
there for future use that doesn't fit that model.
More information about the PVFS2-developers