[PVFS2-developers] 1: small mem/bug fix
robl at mcs.anl.gov
Tue Jun 7 16:50:46 EDT 2005
On Fri, May 27, 2005 at 05:12:05AM -0400, Beilloin, David wrote:
> 1°) small mem leak in src/client/sysint/client-state-machine.c
> details: the first call to PINT_client_state_machine_post create a
> job context through CLIENT_SM_INIT_ONCE but at this level we don't
> know when to free this context
> in src/client/sysint/initialize a PVFS_sys_job_context is allocated
> and freed in src/client/sysint/finalize. as it is not use anywhere,
> I supposed that it was aimed for this ??
> solution : just make pint_client_sm_context point to PVFS_sys_job_context
I don't think I understand your proposed solution very well. Not
saying it's wrong, just that it's dealing with code I'm not terribly
familiar with. Can anybody tell me more about the intended use of
PVFS_sys_job_context and pint_client_sm_context, and if David's
suggestion to just have pint_client_sm_context point to
PVFS_sys_job_context makes sense?
> 2°) small mem leak in src/io/bmi/reference-list.c details: when
> allocating an id_string for new addr reference in BMI_addr_lookup
> this sting is not freed when releasing the reference Solution : just
> do it in ref cleanup !
Good catch. We do this now. Committed to cvs.
> 3°) potential bug in src/io/job/job-desc-queue.c detail : the static
> mutex s_job_desc_q_mutex is allocated each time alloc_job_desc is
> called (then flushing previous allocated pointer) and freed each
> time dealloc_job_desc is called
I used Phil's patch to address this problem. If you want to pull
Thanks for all the patches, David
Mathematics and Computer Science Division A215 0178 EA2D B059 8CDF
Argonne National Labs, IL USA B29D F333 664A 4280 315B
More information about the PVFS2-developers