[PVFS2-developers] patches: misc permission and bug fixes

Phil Carns pcarns at wastedcycles.org
Wed Jun 8 17:42:45 EDT 2005


Here are a few patches that David Metheney and I have been testing.  I 
think they will still apply cleanly to current cvs, but please let me 
know if they don't and I'll adjust them if needed.

Just a heads up for patching; most of them probably need -p0 except for 
  check-mode.patch which will probably need -p1.  Sorry about the 
inconsistency.

Descriptions:

usettable-attr.patch:
Prevents the client library from allowing the dfile_array and 
distribution from being overwritten during a setattr operation.  These 
fields shouldn't be writable once a file is created.

kernel-attr-mask.patch:
May depend on the previous patch, but cleans up the attribute mask 
settings for setattr operations originating from the kernel driver. 
This (in conjunction with the above) was causing the kernel driver to 
set attributes more than it needed to, and actually overwrite the dfile 
array and distribution occasionally.

check-mode.patch:
A rewrite of the main pvfs2 permission checking function to clear up a 
few things:
- fixes a bug in the permission checking logic related in particular to 
group permissions
- more thorough logging (with PERMISSIONS_DEBUG mask), allows you to see 
exactly what causes access to be granted or denied
- takes a new access_type argument rather than overloading the use of 
defines like PVFS_U_READ etc.
- moved to common location in case it is useful for non-server uses one day

supplemental-groups.patch:
Depends on the above patch.  Adds supplemental group permission checking 
rather than just the primary group checking.  The permission checking is 
ordered so that the (marginally more expensive) supplemental group check 
is a last resort if all else fails.

dir-exe-bit.patch:
Depends on the previous two patches.  Makes PVFS2 honor directory 
executable bit permissions properly.

-Phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unsettable-attr.patch
Type: text/x-patch
Size: 1876 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050608/9d94dcc9/unsettable-attr-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kernel-attr-mask.patch
Type: text/x-patch
Size: 2264 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050608/9d94dcc9/kernel-attr-mask-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-mode.patch
Type: text/x-patch
Size: 12769 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050608/9d94dcc9/check-mode-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: supplemental-groups.patch
Type: text/x-patch
Size: 9369 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050608/9d94dcc9/supplemental-groups-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dir-exe-bit.patch
Type: text/x-patch
Size: 6951 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050608/9d94dcc9/dir-exe-bit-0001.bin


More information about the PVFS2-developers mailing list