[PVFS2-developers] patches: misc. bug fixes

Phil Carns pcarns at wastedcycles.org
Thu Jun 30 21:25:54 EDT 2005


attr-proto-size.patch
-----------------------
This is a non-critical bug fix.  It just corrects the maximum size 
calculation for request messages that include attribute structures.  An 
attrib structure can never simultaneously hold information for both a 
symlink and a metafile, but it was reserving enough memory to do so.

error-codes.patch
------------------------
Another not terribly critical bug fix, but could help avoid some 
confusion.  It implements stubs in the kernel module for functions that 
pvfs2 doesn't implement just so that they can return a reasonable error 
code.  Otherwise, the VFS reports EPERM.  The error code this patch 
chooses to report is EOPNOTSUPP.

I don't think the VFS returning EPERM for those functions is 
intentional, but it is easier to get a patch into pvfs2 than into the 
linux kernel :).  More recent optional VFS functions, like the xattr 
family, return EOPNOTSUPP if a module doesn't implement them.  I think 
the link and mknod just go unnoticed because there aren't that many file 
systems that don't implement those functions.

io-error-checking.patch
-------------------------
This fixes some fairly important problems in the kernel module 
read/write path:
- adds some extra write() argument checking that most stock file systems 
get for free (honors rlimits, LFS limits (if applicable), semantics of 
writing beyond eof, read only protection)
- the 2.6 kernel calls an exported function to handle the above bullet, 
but the 2.4 kernel must duplicate a function from the kernel to get this.
- new access_ok() checks to catch bad memory access early
- propigation of error codes out of bufmap component, rather than 
hardcoded error msgs/codes

-Phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: attr-proto-size.patch
Type: text/x-patch
Size: 1333 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050630/7411fb45/attr-proto-size-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: error-codes.patch
Type: text/x-patch
Size: 3067 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050630/7411fb45/error-codes-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: io-error-checking.patch
Type: text/x-patch
Size: 11998 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20050630/7411fb45/io-error-checking-0001.bin


More information about the PVFS2-developers mailing list