[Pvfs2-developers] Re: Gossip'ing kmod

[Sam Lang]

Hi Murali,

Thanks for the patch.  I like the use of sizeof to get the size of a  
static array.  I think we should use that in more places in pvfs  
where possible.  Since kmod_eventlog_to_mask is nearly identical to  
debug_eventlog_to_mask, could you define a generic function that  
works for both, and then some macros or inlined functions that can  
call the generic one?

Also, I've been itching to take the errno macros out of pvfs2- 
error.h, which I believe is defined that way so that functions could  
be defined in both the kernel module as well as userspace code.  So  
if we're going to start sharing source files between the two, maybe  
I'll be able to move that stuff to a source file now?  Are there any  
issues with that from the kernel module perspective?

Thanks,

-sam

On Aug 9, 2006, at 1:48 AM, Murali Vilayannur wrote:

> <gossip-kmod.patch.gz>