[PVFS2-developers] patches: bugfix and new admin util

Phil Carns pcarns at wastedcycles.org
Thu Jan 12 21:09:50 EST 2006


process-request-ret-overflow.patch:
-------------------------
There is a bug in PINT_process_request() that can be triggered through 
io_find_total_size() when reading from very large files near eof, 
therefore causing read operations to fail.  PINT_process_request() has 
an "int" return code, but was returning a 64 bit value through it.  If 
the 64 bit value is large enough it will overflow the int and show up as 
a negative number which is interpreted as an error by io_find_total_size().

This patch changes the semantics slightly so that PINT_process_request() 
instead returns 0 or -PVFS_error rather than returning the number of 
bytes processed on success.  It turns out that no callers were paying 
attention to the exact return code if it was positive anyway, because 
the value is duplicated in the results->bytes field.

pvfs2-perror.patch:
--------------------------
This is a trivial utility that mimics the "perror" command line tool, 
but handles PVFS2 error codes.  It is just a handy way to find out what 
an error code means if you see one in log files/debugger/etc. that has 
not been converted to a string yet.

-Phil

-------------- next part --------------
A non-text attachment was scrubbed...
Name: process-request-ret-overflow.patch
Type: text/x-patch
Size: 3557 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060112/ac99f25a/process-request-ret-overflow.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pvfs2-perror.patch
Type: text/x-patch
Size: 3365 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060112/ac99f25a/pvfs2-perror.bin


More information about the PVFS2-developers mailing list