[Pvfs2-developers] Coalesce patch

[Rob Ross]

agree with everything here.

julian: if there is something we can add in the end comment block to get 
eclipse to do the right thing with indentation etc, please let us know.

thanks,

rob

Sam Lang wrote:
> 
> After seeing the cvs emails about the commit of the patch, I have some 
> style comments.
> 
> * use a new line for opening curly brackets.  This is done throughout 
> the code.
> 
> * don't indent with tab.  The source files have emacs and vi tags (in a 
> comment block at the end) that set the indentation style.  In general, 
> we indent four characters.  Good editors allow the tab key to spit out a 
> set number of characters, often based on the content of the previous 
> line.  This allows the code to look the same everywhere (in vim for me).
> 
> * I think I'm the only one that cares about this one, but I like to 
> limit a line length to 80 characters.  Its just easier to read in my 
> view, than a statement that gets word wrapped somewhere in the middle.
> 
> dbpf-sync.c:54
> 
>     }else{
>         //we should never get here
>         assert(0);
>     }
> 
> * Its best to put the expression in the assert, since on failure the 
> expression is printed.
> 
> * // is a c++ style comment.  always use /* */
> 
> I've made these changes (mostly to dbpf-sync.c), just wanted to let you 
> know for future reference.
> 
> -sam
> 
> 
> On Jul 13, 2006, at 12:15 AM, Sam Lang wrote:
> 
>>
>> Committed to trunk.
>>
>> -sam
>>
>> On Jul 12, 2006, at 5:20 PM, Julian Martin Kunkel wrote:
>>
>>> Hi,
>>>> Can you change the immediate completion flag and send another?
>>> good idea, this stripped some stuff out from the statemachines...
>>>> The case you're probably looking for is if
>>>> the low watermark is set to two, and the queue never gets higher than
>>> Right, that was the case I was looking for.
>>> Its alright, just put 2 in the patchs default settings...
>>>
>>> Thanks,
>>> Julian
>>> <coalesce2.patch>
>>> _______________________________________________
>>> Pvfs2-developers mailing list
>>> Pvfs2-developers at beowulf-underground.org
>>> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>>
>> _______________________________________________
>> Pvfs2-developers mailing list
>> Pvfs2-developers at beowulf-underground.org
>> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>>
> 
> _______________________________________________
> Pvfs2-developers mailing list
> Pvfs2-developers at beowulf-underground.org
> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>