[Pvfs2-developers] Re: BMI TCP socket close for sock buf size

[Sam Lang]

On Jul 13, 2006, at 2:09 PM, Pete Wyckoff wrote:

> As discussed earlier, when setting the TCP socket buffer sizes in
> the config file, the client already has one connection open to a
> server to get the config file.  It's too late to change the buffer
> size for this one connection.  So we need to close it and reopen it
> to fix things.
>
> This little patch just adds the part where the client can get BMI to
> close the socket.  One issue not handled in this patch is:  don't do
> this unless the config file explicitly sets buffer sizes.  The
> bigger problem that sockbuf sizes should not be global settings, but
> rather per-mountpoint, is also not dealt with here.

Hmm..but you are only closing the connection to the address from the  
mountpoint, so unless the same host/port are used for two different  
mountpoints, we should be ok.

>
> 		-- Pete
> <bmi-tcp-close.diff>

I would hate to be labeled the style nazi...but are those curly  
brackets on the same line as the if and case statements? ;-)

-sam