[Pvfs2-developers] Trove patches

[Julian Martin Kunkel]

Hi,
cool link for the ext3 implementation :)

>gen_safe just stores the pointer in a hashtable and returns a hash  
>key in replace of it.  There's no reference counting done on the  
>pointer, so its not a way of implementing smart pointers.
The same issue with test calls and cancel calls directly after that.

>So its an awefully expensive way to show the developer  
>that he has bugs in his code
I doubt that it is so expensive. 
That does not mean the developer has a bug in his code. He can first check if 
the op is completed if not he calls test, however this thread gets 
interrupted before obtaining the mutex and testcontext gets the mutex and 
removes the operation. So the test fails with a segfault. Also the current 
test in progress indication variables do not deal with that issue. (Why are 
they there, anyway ? It seems that the only reason is to avoid calling a test 
and a cancel op at the same time, but the problem of the racecondition still 
remains).

Julan