[Pvfs2-developers] patches: server bugs and logging enhancements

Phil Carns pcarns at wastedcycles.org
Thu May 18 11:51:29 EDT 2006


server-logging.patch:
---------------------
I thought we did this already, but it may have gotten lost in the 
shuffle somewhere.  Anyway, this patch does two things:
- make sure that the "starting" message is always printed both on stdout 
and in the log files when a server starts, regardless of logging mask. 
This is a handy thing to track in server log files.
- don't truncate the server log file on startup

server-err-handling.patch:
---------------------
This one is pretty important.  The logic in getattr and prelude state 
machines was flawed w/ regard to how to interpret error codes from 
reading attributes, and how to interpret attributes that aren't filled 
in properly.  The first case caused it to ignore some types of error 
codes that were properly reported by trove.  The second case amplified 
the problem by allow attributes to pass through the system that don't 
have a valid type field set.  The server should not be able to read 
attributes without a type field set (this should be reported as an 
error).  Another minor cleanup is to detect datafiles by looking at the 
type field, rather than assuming that any object with a mask of 0 is a 
datafile.

rev-lookup-hostnames-runtime.patch:
----------------------
This is an enhancement of a previously accepted patch.  If you wanted to 
resolve hostnames within the ACCESS log type, you previously had to 
specify this at build time with the --enable-rev-hostname option.  This 
patch removes that configure option, and instead replaces it with the 
ability to modify the behavior at runtime.  This is controlled by the 
GOSSIP_ACCESS_HOSTNAMES mask.  That mask doesn't cause any additional 
messages to be printed, but it modifies the GOSSIP_ACCESS_DEBUG mask to 
reverse lookup hostnames rather than displaying ip addresses.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rev-lookup-hostnames-runtime.patch
Type: text/x-patch
Size: 3326 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/a0bc9699/rev-lookup-hostnames-runtime.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: server-err-handling.patch
Type: text/x-patch
Size: 2676 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/a0bc9699/server-err-handling.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: server-logging.patch
Type: text/x-patch
Size: 1405 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/a0bc9699/server-logging.bin


More information about the Pvfs2-developers mailing list