[Pvfs2-developers] patches: system interface cleanups

Phil Carns pcarns at wastedcycles.org
Thu May 18 12:05:22 EDT 2006


msgpairarray-decode.patch:
------------------------
This cleans up how decoding errors (for responses) are handled in 
msgpairarray.  It now saves the error in a slot specific to each 
particular msgpair, so that the problem will show up in EDETAIL if 
possible, rather than as a generic problem with all servers.

sys-immed-complete.patch:
------------------------
I think this may have already been fixed independently by Sam, but we 
can compare notes (I haven't looked at what's in CVS yet).  This makes 
sure that items that complete without the sys wait/test function being 
called get removed from the completion queue properly.  It looks like 
this function just wasn't ever completely filled in.  The most reliable 
way to trigger it is to use mgmt_get_dfile_array() repeatedly (as when 
fscking a large fs).  That function always completes without testing, 
and so after 256 iterations it fills the completion queue and hits an 
assertion.

sys-null-tabfile.patch:
-----------------------
This probably wasn't really hurting much, but the cleanup is good 
anyway.  This patch makes the system interface skip over any tabfiles 
(in its array of tabfiles to try) that are NULL, rather than calling 
open() on them.  The semantics haven't changed with this patch, but we 
don't have to trust the open() function to be polite when we give it a 
NULL parameter.

sys-remove-fsck-warnings.patch:
------------------------
This just adds more verbose error messages to sys-remove to help track 
down a problem.  We did find an issue later, I think, but I don't have 
that patch ready yet.

-Phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msgpairarray-decode.patch
Type: text/x-patch
Size: 1108 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/88400ef6/msgpairarray-decode-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sys-immed-complete.patch
Type: text/x-patch
Size: 1340 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/88400ef6/sys-immed-complete-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sys-null-tabfile.patch
Type: text/x-patch
Size: 1858 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/88400ef6/sys-null-tabfile-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sys-remove-fsck-warnings.patch
Type: text/x-patch
Size: 1779 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060518/88400ef6/sys-remove-fsck-warnings-0001.bin


More information about the Pvfs2-developers mailing list