[Pvfs2-developers] patches: acl test cleanups

Phil Carns pcarns at wastedcycles.org
Tue Sep 5 14:31:44 EDT 2006


These patches clean up the remaining issues from the tacl_xattr.sh test 
script (this is easy stuff- Murali did all of the hard work).

tacl-xattr-homedir.patch:
-------------------------
This makes tacl-xattr.sh slightly more portable.  Some Linux 
distributions have adduser utilities that do not create the home 
directory for you.  This patch explicitly does a mkdir -p and chmod 
after adduser to make sure that required home directories exist.

tacl-xattr-symlink.patch:
-------------------------
This is an important fix to the test script.  It was using the -L 
argument to getfattr to traverse symbolic links when dumping the ACLs 
from the test directory.  This leads to unpredictable results because 
there was no way to tell whether getfattr would traverse a real 
directory or its symbolic link first (it depends on the dirent order) 
and the other would always be left out.  ACLs are not supported on 
symbolic links anyway, so it was just adding noise to the test script.

xattr-symlink.patch:
-------------------------
This is the only change to PVFS2 itself.  Like most Linux file systems, 
PVFS2 does not support xattrs on symbolic links (despite what is implied 
by man pages).  This is due to the fact that symbolic links have 777 
permissions by default that would allow anyone on the system to store 
xattrs in any symbolic link.  This patch updates PVFS2 semantics 
slightly, however, to be more in line with how other file systems 
implement this.  In particular listxattr() is now allowed (it just 
returns that there are zero entries), and setxattr() is implemented to 
return EPERM rather than EOPNOTSUPP.

-Phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tacl-xattr-homedir.patch
Type: text/x-patch
Size: 773 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060905/70090034/tacl-xattr-homedir.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tacl-xattr-symlink.patch
Type: text/x-patch
Size: 532 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060905/70090034/tacl-xattr-symlink.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xattr-symlink.patch
Type: text/x-patch
Size: 2168 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20060905/70090034/xattr-symlink.bin


More information about the Pvfs2-developers mailing list