[Pvfs2-developers] patches: misc small fixes

Phil Carns pcarns at wastedcycles.org
Thu Apr 5 16:55:41 EDT 2007


These are all pretty minor:

mod-parm-desc.patch:
--------------------
The pvfs2 kernel module is missing the parameter description for the 
op_timeout_secs option that can be set at insmod time.

server-gossip-errno.patch:
--------------------------
The pvfs2-server is trying to use errno to propigate errors from 
gossip_enable_file(), but this function returns its error code in the 
return value.  I think maybe the errno handling logic may have just been 
mistakenly pasted from the fopen() error handling earlir in this same file.

mgmt-getconfig-wait.patch:
--------------------------
I don't think this makes a significant difference, but all of the 
mgmt*.sm state machines are using mgmt_wait and mgmt_release to handle 
their operations, except for mgmt-getconfig which is using sys_wait and 
sys_release.  This patch updates mgmt-getconfig to match the other mgmt 
state machines.

pvfs2-rm.patch:
---------------
This is an old patch that apparently just forgot to submit a long time 
ago.  At any rate, it makes two changes to pvfs2-rm.  First of all, it 
updates pvfs2-rm to use the gen_credentials() function to fill in its 
credentials rather than manually setting the credential fields.  It also 
introduces some extra sanity checking on removal of objects that appear 
to be directories.  I think some error handling has been beefed up 
elsewhere since the time this patch was generated, so the sanity check 
isn't as important any more- but it does still result in a better error 
message if you try to remove a normal file as if it is a directory.

-Phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mgmt-getconfig-wait.patch
Type: text/x-patch
Size: 804 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070405/e2893601/mgmt-getconfig-wait.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mod-parm-desc.patch
Type: text/x-patch
Size: 646 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070405/e2893601/mod-parm-desc.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pvfs2-rm.patch
Type: text/x-patch
Size: 2757 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070405/e2893601/pvfs2-rm.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: server-gossip-errno.patch
Type: text/x-patch
Size: 656 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070405/e2893601/server-gossip-errno.bin


More information about the Pvfs2-developers mailing list