[Pvfs2-developers] viewdist get-eattr endianness

Sam Lang slang at mcs.anl.gov
Mon Apr 16 15:05:05 EDT 2007


On Apr 16, 2007, at 12:35 PM, Pete Wyckoff wrote:

> slang at mcs.anl.gov wrote on Mon, 16 Apr 2007 11:52 -0500:
>> Attached is a patch that tries to get viewdist working properly when
>> client and server have different endianness.  The basic issue was
>> that viewdist uses get-eattr to get the datafile handle array, which
>> prevents the encoding/decoding of the handles.  The attached patch
>> adds encoding/decoding to known extended attributes (those in the
>> system.pvfs2. namespace).
>
>> +struct PINT_handle_array
>> +{
>> +    int32_t count;
>> +    PVFS_handle *handles;
>> +};
>> +endecode_array(PINT_handle_array, struct PINT_handle_array,
>> +               int32_t, count,
>> +               PVFS_handle, handles);
>> +
>
> Could I talk you into endecode_fields_0a_struct() instead?  All the
> aggregate encoders have that sort of name, with "fields" in it.  The
> primitives like int64 have endecode_int64_t.  But you're not adding
> a primitive array encoder, but another aggregate.  I think of
> struct PINT_handle_array as being like PVFS_handle_extent_array.

Ok.  Maybe I should just use fields_1a_struct and skip4 at the  
beginning.

-sam

>
> 		-- Pete
>



More information about the Pvfs2-developers mailing list