[Pvfs2-developers] pvfs2 2.6.3 fixes

[slang]

>
> > I'd prefer to fix the check for kmem_cache in TRY_COMPILE, rather  
> than grep.
> > We should be able to add some bits to the second parameter to  
> TRY_COMPILE.
> > Probably something like:
>
> > AC_TRY_COMPILE([
> > 		#define __KERNEL__
> > 		#include <linux/slab.h>
> > 		static struct kmem_cache;
> > 	],
> > 	[
> > 		struct kmem_cache *c;
> > 		c = kmem_cache_create(NULL, 0, 0, 0, NULL, NULL);
> > 	],
> > 	...
>
> This will also always succeed (with warnings).  "static struct  
> kmem_cache"
> will declare "struct kmem_cache" even if <linux/slab.h> doesn't.

You're right about the static struct kmem_cache, but that's the point  
of the second block.  If kmem_cache_create returns kmem_cache_t,  
setting it to a struct kmem_cache * should cause a type conversion  
error.

> > Seems fine.  I do out of tree builds all the time though, so I'm  
> curious how
> > this broke for you.  Are you creating symlinks of the pvfs tree or
> > something?
>
> Yes, that's what shadow trees are.  See `lndir`.  I use them to  
> facilitate
> the generation of patches.  To do that, I must prevent any  
> modification of
> the base tree.

To each his own, but creating symlinks seems like the hard way  
around.  Why not just run configure in a separate directory to do out  
of tree builds?

-sam