[Pvfs2-developers] add run func declaration automagically

Sam Lang slang at mcs.anl.gov
Wed Aug 29 20:13:37 EDT 2007


On Aug 29, 2007, at 3:59 PM, Pete Wyckoff wrote:

> slang at mcs.anl.gov wrote on Wed, 29 Aug 2007 13:21 -0500:
>> Attached is a patch that adds the run func declaration to the C
>> source file from the statecomp, so that we don't have to add them
>> manually.  I went through and removed all the declarations in the .sm
>> files we have in the source, but I know you've got your state
>> machines going, so I wanted to pass it by you before I committed it
>> and broke your builds.
>
> Very nice cleanup.  (Except for the #includes not at the top of the
> file in statecomp stuff.  Gives me the willies.)

Willies can really kill your productivity.  I've fixed those.

>   The build errors
> for our out-of-tree stuff will be pretty easy to fix once this goes
> in.  Thanks for sending it out.

They're actually just warnings, so if you go to get coffee you won't  
even notice.  I've committed the patch.
-sam

>
> 		-- Pete
>



More information about the Pvfs2-developers mailing list