[Pvfs2-developers] bdb.m4 uninitialized variables break default Fedora Core 5 build

[Sam Lang]

On Jan 19, 2007, at 6:53 AM, Number Cruncher wrote:

> I'm using RPM to simplify installation and can't build pvfs-2.6.2  
> on FC5 using the default RPM compiler build flags which include "- 
> Werror" on FC5.
>
> This breaks the configure test for HAVE_TXNID_PARAMETER_TO_DB_OPEN  
> because the parameters are used uninitialized. The test fails  
> silently but the system installed BDB does require the TXNID  
> parameter which breaks the subsequent build:
>
> src/io/trove/trove-dbpf/dbpf-mgmt.c: In function 'dbpf_getdb_env':
> src/io/trove/trove-dbpf/dbpf-mgmt.c:98: warning: passing argument 2  
> of 'dbenv->set_errcall' from incompatible pointer type
> src/io/trove/trove-dbpf/dbpf-mgmt.c: In function 'db_open':
> src/io/trove/trove-dbpf/dbpf-mgmt.c:1653: warning: passing argument  
> 2 of 'db_p->open' from incompatible pointer type
> src/io/trove/trove-dbpf/dbpf-mgmt.c:1653: warning: passing argument  
> 4 of 'db_p->open' makes pointer from integer without a cast
> src/io/trove/trove-dbpf/dbpf-mgmt.c:1653: error: too few arguments  
> to function 'db_p->open'
>
> Workaround: overwrite default compiler flags.
>
> Fix: initialize variables in pvfs-2.6.2/maint/config/bdb.m4  
> HAVE_TXNID_PARAMETER_TO_DB_OPEN macro.

We have nightly tests running on FC6...odd that it doesn't use - 
Werror but FC5 does.  I've committed these fixes to the 2.6 branch  
and attached a patch of the changes.  They seem to work on FC6, but  
then so does the code without the patch.  If you get a chance, let me  
know how the patch goes on FC5.

Thanks,

-sam

>
>
> Thanks,
> Simon
> _______________________________________________
> Pvfs2-developers mailing list
> Pvfs2-developers at beowulf-underground.org
> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>