[Pvfs2-developers] Re: [Pvfs2-cvs] commit by slang in pvfs2: Makefile.in configure configure.in pvfs2-config.h.in

[Sam Lang]

Hi Pete,

On Jul 18, 2007, at 9:34 AM, Pete Wyckoff wrote:

> cvs at parl.clemson.edu wrote on Wed, 18 Jul 2007 03:02 -0400:
>> diff -p -u -r1.242 -r1.243
>> --- Makefile.in	28 May 2007 22:40:55 -0000	1.242
>> +++ Makefile.in	18 Jul 2007 07:02:27 -0000	1.243
>> @@ -257,7 +257,7 @@ GCC_CFLAGS := -pipe -Wall -Wstrict-proto
>>  #
>>  #SERVERCFLAGS = -D__GEN_POSIX_LOCKING__ -D__PVFS2_TROVE_SUPPORT__
>>
>> -SERVERCFLAGS = -D__GEN_POSIX_LOCKING__ -D__PVFS2_JOB_THREADED__ \
>> +SERVERCFLAGS = @CFLAGS@ -D__GEN_POSIX_LOCKING__ - 
>> D__PVFS2_JOB_THREADED__ \
>>  -D__PVFS2_TROVE_THREADED__ @MISC_TROVE_FLAGS@ @DB_CFLAGS@ \
>>  -D__PVFS2_TROVE_SUPPORT__ -D__PVFS2_SERVER__
>
> Confused.  Every command that includes SERVERCFLAGS also includes
> CFLAGS.  Why do you need a second copy of CFLAGS?

I was trying to do profiling so I set my CFLAGS=-pg environment  
variable.  None of the server sources were getting -pg in their  
compile lines though, and adding that seemed to do the trick.  I  
haven't looked into it, but I think the reason is that the CFLAGS  
env. var. is grabbed by configure and replaces the @CFLAGS@ in the  
Makefile.in, but the actual $CFLAGS variable in the Makefile isn't  
actually getting set.  There should probably just be a:

CFLAGS += @CFLAGS@

In the Makefile.in I guess.

>
>> diff -p -u -r1.317 -r1.318
>> --- configure.in	9 Jun 2007 20:36:57 -0000	1.317
>> +++ configure.in	18 Jul 2007 07:02:29 -0000	1.318
>> @@ -786,6 +786,10 @@ if test -n "$MX_HOME" ; then
>>      AC_CHECK_HEADER(myriexpress.h,, AC_MSG_ERROR([Header  
>> myriexpress.h not found.]))
>>      BUILD_MX=1
>>      CPPFLAGS="$CPPFLAGS_OLD"
>> +    CFLAGS="${CFLAGS} -I${MX_HOME}/include"
>> +    LDFLAGS="$LDFLAGS -L${MX_HOME}/lib"
>> +    SERVER_LDFLAGS="$SERVER_LDFLAGS -L${MX_HOME}/lib"
>> +    LIBS="$LIBS -lmyriexpress"
>>  fi
>
> All the other BMI implementations don't modify CFLAGS at this stage.
> There is a chunk in Makefile.in that does so depending on calculated
> MX_HOME, e.g.  MX already has one of these too.  Why is this
> necessary?

It might not be.  I added it a while back because it wasn't building,  
and now I don't remember the issue.  I can revert it until I run into  
the problem again.

-sam

>
>> @@ -1163,6 +1167,8 @@ doc/random/module.mk
>>  examples/pvfs2-server.rc
>>  doc/doxygen/pvfs2-doxygen.conf
>>  )
>> +
>> +chmod $BUILD_ABSOLUTE_TOP/src/apps/admin/pvfs2-config
>
> Does this even work?  Maybe "+x"?
>
> 		-- Pete
>