[Pvfs2-developers] patches: permission/acl bug fixes

[Sam Lang]

On Mar 27, 2007, at 3:53 PM, Phil Carns wrote:
>
> I like the structure of the patch in that it cleans the xattr  
> namespace translation goop out of the state machines.
>
> I think that this may break something, though.  Could you confirm  
> with the test/automated/tacl_xattr.sh script on your end?  I may  
> have done something wrong, but this test appears to work fine  
> without the attached patch, but then has some failures if I apply it.

Hi Phil,

There were some bugs in that patch, yeah.  I've attached another  
patch that fixes them.  Even without the patch, tacl_xattr.sh reports  
failures, but now the failures with and without the patch are the  
same.  I've attached the output of the tacl script for with and  
without the patch cases.  Do you get those failures?

>
> As a side note, it looks like there are still some noisy messages  
> coming from the kernel related to ACLs regardless of whether the  
> patches are applied or not.  The tacl_xattr.sh script generates  
> several of these in dmesg for me:
>
> pvfs2_acl_chmod: get acl (access) failed with 0
>
> They also pop out during LTP test runs.

Attached patch should also fix those.  I think the error checking was  
just a little bit wrong.

-sam


-------------- next part --------------
A non-text attachment was scrubbed...
Name: eattr-callouts4.patch
Type: application/octet-stream
Size: 29193 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070328/892a5e55/eattr-callouts4-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tacl-out-no-patch
Type: application/octet-stream
Size: 4448 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070328/892a5e55/tacl-out-no-patch-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tacl-out-with-patch
Type: application/octet-stream
Size: 4448 bytes
Desc: not available
Url : http://www.beowulf-underground.org/pipermail/pvfs2-developers/attachments/20070328/892a5e55/tacl-out-with-patch-0001.obj
-------------- next part --------------

>
> -Phil
>
>
>