[Pvfs2-developers] PATCH: src/io/trove/trove-dbpf/dbpf-mgmt.c

[Sam Lang]

Hi Kevin,

Looks good, thanks for sending this patch to the list.  I think its  
generally accepted that minor stuff (debug statements for example)  
get committed directly.  Since we're here though, our logging is  
horribly unstructured (we're running out of bits in the uint64_t  
space).  Its often hard to figure out what log levels to set to get  
the information you want (its usually more than one), but setting to  
all or verbose ends up being too much info.  Anyone have ideas on how  
we can make it more useful?  Provide some kind of verbosity levels,  
or group log levels?

Also, the error itself in Kevin's example could probably be more  
helpful:

failure removing storage space: Permission denied

Should be something like:

failure removing storage space //pvfsdata/test/fs1-surveyor:  
Permission denied

Right now the only way to do that is with two statements:

PVFS_perror_gossip("failure removing storage space", errno);
gossip_err("%s", storage_path);

We might have a single gossip call:

gossip_err_error(PVFS_error, const char * format, ...);

for example.  Seem reasonable?

-sam

On Sep 5, 2007, at 5:59 PM, Kevin Harms wrote:

>
> 	Added a debug output when removing the storage directory.
>
> 	sample output:
>
>     harms at fs1[~]: ~/software/sbin/pvfs2-server --rmfs ~/pvfs2-test/ 
> fs.conf
>     [S 09/05 17:40] PVFS2 Server on node fs1 version  
> 2.7.0pre1-2007-09-05-220717 starting...
>     [D 17:40:52.197864] dbpf_thread_initialize: initialized
>     [D 17:40:52.198001] dbpf_thread_function started
>     [D 17:40:52.201153] Removing //pvfsdata/test/fs1-surveyor/ 
> storage_attributes.db
>     [D 17:40:52.201297] Removing //pvfsdata/test/fs1-surveyor/ 
> collections.db
> ->  [D 17:40:52.201380] Removing //pvfsdata/test/fs1-surveyor
>     failure removing storage space: Permission denied
>     [D 17:40:52.213966] dbpf_thread_function ending
>     [D 17:40:52.214014] dbpf_thread_finalize: finalized
>
>
> Kevin Harms
>
> Index: src/io/trove/trove-dbpf/dbpf-mgmt.c
> ===================================================================
> RCS file: /projects/cvsroot/pvfs2/src/io/trove/trove-dbpf/dbpf- 
> mgmt.c,v
> retrieving revision 1.98
> diff -a -u -p -r1.98 dbpf-mgmt.c
> --- src/io/trove/trove-dbpf/dbpf-mgmt.c 15 Mar 2007 21:45:23  
> -0000      1.98
> +++ src/io/trove/trove-dbpf/dbpf-mgmt.c 5 Sep 2007 22:48:02 -0000
> @@ -664,6 +664,7 @@ int dbpf_storage_remove(char *stoname,
>      }
>
>      DBPF_GET_STORAGE_DIRNAME(path_name, PATH_MAX, stoname);
> +    gossip_debug(GOSSIP_TROVE_DEBUG, "Removing %s\n", path_name);
>      if (rmdir(path_name) != 0)
>      {
>          perror("failure removing storage space");
>
> _______________________________________________
> Pvfs2-developers mailing list
> Pvfs2-developers at beowulf-underground.org
> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>