[Pvfs2-developers] Small patch to install the shared libraries if you configure with --enable-threaded-kmod-helper

Pete Wyckoff pw at padd.com
Thu Jul 3 15:45:33 EDT 2008


tonykew at ccr.buffalo.edu wrote on Thu, 03 Jul 2008 14:34 -0400:
> Hear is a trivial patch to install the shared libraries if you use
> the --enable-threaded-kmod-helper  configure option.
> The patch is against 2.7.1

I was the last one to toy around in this area.  This change looks
good to me.  My only head-scratching is whether these libs should
be installed with kmod_install, rather than in the "install" step.
But that seems like more of a mess than the purity of separating
these wound warrant.

I'd appreciate it if someone else would concur, and put this in the
tree.

> Using the threaded kmod helper didn't work for me, incidentally,
> so I'm not using the option...

Yeah.

		-- Pete

> --- Makefile.in.orig	2008-04-14 11:37:32.000000000 -0400
> +++ Makefile.in	2008-05-23 10:20:34.000000000 -0400
> @@ -447,12 +447,14 @@ LIBRARIES_THREADED :=
>  ifeq ($(build_shared),yes)
>  LIBRARIES_SHARED = lib/libpvfs2.so
>  LIBRARIES += $(LIBRARIES_SHARED)
> -LIBRARIES_THREADED += lib/libpvfs2-threaded.so
> +LIBRARIES_THREADED_SHARED += lib/libpvfs2-threaded.so
> +LIBRARIES_THREADED += $(LIBRARIES_THREADED_SHARED)
>  endif
>  ifeq ($(build_static),yes)
>  LIBRARIES_STATIC = lib/libpvfs2.a
>  LIBRARIES += $(LIBRARIES_STATIC)
> -LIBRARIES_THREADED += lib/libpvfs2-threaded.a
> +LIBRARIES_THREADED_STATIC += lib/libpvfs2-threaded.a
> +LIBRARIES_THREADED += $(LIBRARIES_THREADED_STATIC)
>  endif
>  
>  ################################################################
> @@ -933,6 +935,11 @@ ifneq (,$(LIBRARIES_STATIC))
>  	for i in $(notdir $(LIBRARIES_STATIC)) ; do \
>  	    install -m 755 lib/$$i $(libdir) ;\
>  	done
> +ifneq (,$(KERNAPPSTHR))
> +	for i in $(notdir $(LIBRARIES_THREADED_STATIC)) ; do \
> +	    install -m 755 lib/$$i $(libdir) ;\
> +	done
> +endif
>  endif
>  ifneq (,$(LIBRARIES_SHARED))
>  	for i in $(notdir $(LIBRARIES_SHARED)) ; do \
> @@ -940,6 +947,13 @@ ifneq (,$(LIBRARIES_SHARED))
>  	    $(LN_S) $$i.$(SO_FULLVER) $(libdir)/$$i.$(SO_VER) ;\
>  	    $(LN_S) $$i.$(SO_VER) $(libdir)/$$i ;\
>  	done
> +ifneq (,$(KERNAPPSTHR))
> +	for i in $(notdir $(LIBRARIES_THREADED_SHARED)) ; do \
> +	    install -m 755 lib/$$i $(libdir)/$$i.$(SO_FULLVER) ;\
> +	    $(LN_S) $$i.$(SO_FULLVER) $(libdir)/$$i.$(SO_VER) ;\
> +	   $(LN_S) $$i.$(SO_VER) $(libdir)/$$i ;\
> +	done
> +endif
>  endif
>  
>  ifdef TARGET_OS_DARWIN




More information about the Pvfs2-developers mailing list