[Pvfs2-developers] Re: [PATCH] modify twod-stripe's default params and add some documentation

[Phil Carns]

I went ahead and committed the portion of the patch that adds more 
comments to the twod_stripe code for now.

-Phil

Kyle Schochenmaier wrote:
> Patch is against cvs head, and modifies the default num_groups to be 1
> and the group_strip_factor = 1  so twod-stripe's defaults still work
> when you use it on a single-server, it will now by default behave the
> same as simple-stripe until the user modifies the num_groups and
> strip_factor xattrs.
> 
> Also added a brief description of the definitions for the dist_params
> in twod-stripe.
> 
> Tested fully functional on my servers.
> 
> Kyle
> 
> 
> Index: src/io/description/dist-twod-stripe.c
> ===================================================================
> RCS file: /anoncvs/pvfs2/src/io/description/dist-twod-stripe.c,v
> retrieving revision 1.5
> diff -r1.5 dist-twod-stripe.c
> 6a7,15
>> /* twod-stripe will take all of the servers in the filesystem and
>>  * partition them into num_groups groups.  Data will then be striped to
>>  * each group before we move onto the next group.  The strip_factor will
>>  * determine how many chunks of strip_size are written to each server
>>  * in each group before we transition to the next group.
>>  * The striping on the group level is done round-robin in the same
>>  * fashion as simple-stripe
>>  */
>>
> 
> 
> Index: include/pvfs2-dist-twod-stripe.h
> ===================================================================
> RCS file: /anoncvs/pvfs2/include/pvfs2-dist-twod-stripe.h,v
> retrieving revision 1.4
> diff -r1.4 pvfs2-dist-twod-stripe.h
> 17c17
> < #define PVFS_DIST_TWOD_STRIPE_DEFAULT_GROUPS 2
> ---
>> #define PVFS_DIST_TWOD_STRIPE_DEFAULT_GROUPS 1
> 19c19
> < #define PVFS_DIST_TWOD_STRIPE_DEFAULT_FACTOR 256
> ---
>> #define PVFS_DIST_TWOD_STRIPE_DEFAULT_FACTOR 1
> 
> 
> -
> Kyle Schochenmaier
>