[Pvfs2-developers] Review : Get PVFS2 exports working with NFS

[Phil Carns]

Thanks Murali.  I went ahead and committed this to cvs head.  I only 
found one spot that needed an extra up_read() call.

I'll try building it on a few older systems today as well to see if we 
need any extra configure tests for older kernels.  Otherwise it looks 
fine to me.

-Phil

Murali Vilayannur wrote:
> Hi Emmanuel, Phil,
> 
> I had sent the patch to get file_aio_write_iovec reimplemented
> correctly several months ago.
> http://www.beowulf-underground.org/pipermail/pvfs2-users/2007-October/002127.html
> I think it never made its way to HEAD and I also dropped the ball on
> that since I did not hear
> back from Emmanuel on whether it actually worked for him. Sorry about that.
> 
> Attached patch respins the same diffs against HEAD along with the
> earlier version that I had sent out last week
> also against HEAD and allows NFS exports to work correctly (tested
> pvfs2 building,
> cp, dd, large file I/Os, VM powering up etc)
> over PVFS2.
> Phil/Sam: I might be missing a few semaphore up() on error paths. I
> haven't followed the error/cleanup paths
> that carefully. Would be good if you guys can take a careful look at
> pvfs2-bufmap.c error paths since the RW
> semaphore seems to be a recent change.
> 
> Emmanuel, can you test this against HEAD on your setup and let me know
> if it works?
> Thanks,
> Murali
> 
>  configure                           |  116 ++++++++++
>  maint/config/kernel.m4              |   26 ++
>  pvfs2-config.h.in                   |    6
>  src/kernel/linux-2.6/devpvfs2-req.c |    8
>  src/kernel/linux-2.6/file.c         |  127 +++++++---
>  src/kernel/linux-2.6/inode.c        |    2
>  src/kernel/linux-2.6/pvfs2-bufmap.c |  417 ++++++++++++++++++++----------------
>  src/kernel/linux-2.6/pvfs2-bufmap.h |   11
>  src/kernel/linux-2.6/pvfs2-kernel.h |    3
>  src/kernel/linux-2.6/super.c        |  104 ++++++++
>  10 files changed, 588 insertions(+), 232 deletions(-)
> 
> 
> On Thu, Jun 5, 2008 at 3:49 AM, Emmanuel Florac <eflorac at intellique.com> wrote:
>> Le Thu, 5 Jun 2008 12:39:48 +0200
>> Emmanuel Florac <eflorac at intellique.com> écrivait:
>>
>>> Weird, I tried this (on x86_64) and it still complains about
>>> pvfs2_file_aio_write_iovec not implemented yet. I did only recompile
>>> the kernel module, is it the problem?
>>> I just checked out the latest CVS five minutes ago (unless the public
>>> CVS is actually late?)
>> Well no, I've just had a look at the source... It works fine, reading,
>> moving files around, mkdir, but can't write more than 45MB (less than
>> that it's OK with dd or cat, but not cp).
>>
>> --
>> ----------------------------------------
>> Emmanuel Florac     |   Intellique
>> ----------------------------------------
>>
>>
>> _______________________________________________
>> Pvfs2-developers mailing list
>> Pvfs2-developers at beowulf-underground.org
>> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Pvfs2-developers mailing list
>> Pvfs2-developers at beowulf-underground.org
>> http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers