[Pvfs2-developers] Re: Potentially useful build patches.

[Pete Wyckoff]

jsbronder at gentoo.org wrote on Thu, 13 Mar 2008 17:54 -0400:
> Done.  I've attached 2.7.0-branch-destdir-sover.patch that does just this.

Out for comments.

> On 12/03/08 14:35 -0400, Pete Wyckoff wrote:
> > I thought that was what just_kmod did.  Maybe you want something else?
> 
> Yeah, I don't want to build kernapps when I build the kernel module.  For
> instance, on a ppc64 machine, I may have a 32-bit userland, but still utilize
> the 64 bit kernel.  Things break down when the kernel ABI differs from
> userland.  Note, that I'm far from an expert here, just had to deal with this
> a lot on some Xserves :)

You can use "make kernapps" to build just the apps.  Seems to work.
If you want just the kernel module, "make just_kmod".  And "make
kmod" to do both.

> Actually, I initially believed you needed both, but pkg-config and some quick
> testing tells me I'm wrong.  You only need -lcrypto.

It was getting pulled in automatically by other bits in -lssl, but I
made it explicit.  Thanks.

> > Just yesterday or so I may have fixed this one a different way:
> > 
> >     http://www.pvfs.org/fisheye/changelog/PVFS/?cs=MAIN:pw:20080311153354
> > 
> > Maybe there is some other need for changing the no-strict-alias
> > arg, but I think what's in CVS should address the bug report.
> 
> Just got confirmation now that the above patch fixed this.  I would note that
> the problem was with -Wno-strict-aliasing=2 and it seems that in this commit
> you removed the code that added $extra_gcc_flags to CFLAGS.  I'm not sure if
> that was your intention?

It wasn't my intention, but it seems like the right thing to do,
in retrospect.  I yanked out the clause that calculates the
extra_gcc_flags.  I'm glad somebody reads my checkins.  :)

		-- Pete