[Pvfs2-users] build issues during upgrade

[Dries Kimpe]

I'm sorry but your commit doesn't solve the problem;
The problem is not with CFLAGS,
the problem is that SERVERCFLAGS (which comes before CFLAGS on the compiler command line)
includes a directory which *could* (and will in an upgrade scenario) contain (potentially incompatible)
PVFS2 header files.

To solve this, either switch the order of SERVERCFLAGS and CFLAGS in the make rules,
or add -I $(srcdir)/include (also) to SERVERCFLAGS.

  Greetings,
  Dries

Sam Lang wrote:
> 
> This is sort of an odd case, but adding the -I $(srcdir)/include at the
> front of CFLAGS seems harmless.  I'll commit the change.
> 
> -sam

>>
>>
>> Note that the first include directory specified is:
>> -I/data/home/dries/inst/nompi/include/,
>> This gets there because of:
>>
>> SERVERCFLAGS = -D__GEN_POSIX_LOCKING__ -D__PVFS2_JOB_THREADED__ \
>> -D__PVFS2_TROVE_THREADED__ @MISC_TROVE_FLAGS@ @DB_CFLAGS@ \
>> -D__PVFS2_TROVE_SUPPORT__ -D__PVFS2_SERVER__
>>
>> (with @DB_CFLAGS@ getting replaced by
>> -I/data/home/dries/inst/nompi/include)
>>
>> and the compile line for the objects is:
>>
>> $(ADMINOBJS_SERVER): %.o: %.c
>>         $(Q) "  CC              $@"
>>         $(E) $(CC) $(SERVERCFLAGS) $(CFLAGS) $(call modcflags,$<) $<
>> -c -o $@
>>
>>
>> This makes the compiler use the OLD PVFS2 headers as opposed to the
>> new, causing the
>> build to fail.
>>
>> Solution: adding -I $(srcdir)/include to SERVERCFLAGS or causing this
>> flag to be earlier on the
>> compiler command line by other means.
>>